Attention is currently required from: Wonkyu Kim, Anastasia Klimchuk.

View Change

5 comments:

• Commit Message:

  • Patch Set #1, Line 12: TEST=

    Could you also validate the chip detection logic just as we did in https://review.coreboot. […]

    Ack

  • Patch Set #1, Line 18:

    rom
    the chipset name.
    

    line wrap.

    Ack

• File ich_descriptors.c:

  • Patch Set #1, Line 118: ",

    missing from here too.

    Ack

  • Patch Set #1, Line 1048:

    		if (content->CSSL == 0x03) {
    			if (content->CSSO == 0x70)
    				return CHIPSET_METEOR_LAKE;
    

    Can you elaborate on this part in the commit message to justify this will not regress Elkhart Lake d […]

    Ack

• File util/ich_descriptors_tool/ich_descriptors_tool.c:

  • Patch Set #1, Line 130: "\t- \"gemini\" for Intel's Gemini Lake SoC.\n"

    missing line here

    Ack

To view, visit change 62783. To unsubscribe, or for help writing mail filters, visit settings.