Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Add support for USB SPI protocol V2 ......................................................................
Patch Set 12: Code-Review+1
(3 comments)
https://review.coreboot.org/c/flashrom/+/41533/12/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/12/raiden_debug_spi.c@1154 PS12, Line 1154: write_attempt = 0 I'd prefer to keep the initialization inside the loop head, but keep the declaration here:
unsigned int write_attempt;
Then:
for (write_attempt = 0; write_attempt < WRITE_RETRY_ATTEMPTS; write_attempt++) {
https://review.coreboot.org/c/flashrom/+/41533/12/raiden_debug_spi.c@1212 PS12, Line 1212: for (; read_attempt < READ_RETRY_ATTEMPTS; : read_attempt++) { Here you definitely want to initialize the variable in the loop head:
for (read_attempt = 0; read_attempt < READ_RETRY_ATTEMPTS; read_attempt++) {
Also add a newline before
https://review.coreboot.org/c/flashrom/+/41533/12/raiden_debug_spi.c@1338 PS12, Line 1338: it's nit: possessive `its`