Patch set 12:Code-Review +1

3 comments:

File raiden_debug_spi.c:
- Patch Set #12, Line 1154: write_attempt = 0
  I'd prefer to keep the initialization inside the loop head, but keep the declaration here:
```
 unsigned int write_attempt;
```
  Then:
```
 for (write_attempt = 0; write_attempt < WRITE_RETRY_ATTEMPTS; write_attempt++) {
```
- Patch Set #12, Line 1212:
```
for (; read_attempt < READ_RETRY_ATTEMPTS;
				read_attempt++) {
```
  Here you definitely want to initialize the variable in the loop head:
```
 for (read_attempt = 0; read_attempt < READ_RETRY_ATTEMPTS; read_attempt++) {
```
  Also add a newline before
- Patch Set #12, Line 1338: it's
  nit: possessive `its`

To view, visit change 41533. To unsubscribe, or for help writing mail filters, visit settings.