[flashrom-gerrit] [M] Change in flashrom[main]: flashchips: Add support for MXIC MX25U25645G

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer.

Anastasia Klimchuk has posted comments on this change by DZ. ( https://review.coreboot.org/c/flashrom/+/82777?usp=email )

Change subject: flashchips: Add support for MXIC MX25U25645G
......................................................................

Patch Set 1:

(3 comments)

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/82777/comment/578e93b9_f67537ab?usp... :
PS1, Line 11104: 512B
Datasheet says `8K-bit secured OTP` so I think this is 1024B

https://review.coreboot.org/c/flashrom/+/82777/comment/534bf2b2_4d87f9b0?usp... :
PS1, Line 11111: {
               : 				.eraseblocks = { {4 * 1024, 8192} },
               : 				.block_erase = SPI_BLOCK_ERASE_21,
               : 			},
I don't see it in datasheet (I mean: 21h, 5Ch, DCh)? I see there is:

20h for 4K
52h for 32K
D8h for 64K
60h or C7h for chip erase

I am looking at sections 10-24 and to 10-27 which describe erase commands?

https://review.coreboot.org/c/flashrom/+/82777/comment/05089391_e1ed2a9e?usp... :
PS1, Line 11137: /* TODO: security register */
You can remove TODO, you added security register bits below