[flashrom-gerrit] [M] Change in flashrom[master]: Replace all flashchips accesses with get functions

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75646?usp=email )

Change subject: Replace all flashchips accesses with get functions
......................................................................

Patch Set 5:

(11 comments)

Patchset:

PS5: 
I realise this patch was a intermediate step so the comments are just how it should probably look for when the desire to merge comes about.

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/75646/comment/1a29ee84_6580ba0a :
PS5, Line 34: internal_
no need to rename if it becomes static, also "internal" is a overloaded term with the internal programmer.

https://review.coreboot.org/c/flashrom/+/75646/comment/efe728fb_a207593b :
PS5, Line 20844: get_flashchips(void)
you *could* have a signature of:

`void get_flashchip_db(struct flashchip **db, size_t *len)` ?

https://review.coreboot.org/c/flashrom/+/75646/comment/37be779e_1568c5f4 :
PS5, Line 20849: unsigned int
should be `size_t` for the size of an array.

File ichspi.c:

https://review.coreboot.org/c/flashrom/+/75646/comment/94da9d4a_c9a16f09 :
PS5, Line 1469: 	const struct flashchip *chip;
              : 
              : 	struct flashchip *flashchips=get_flashchips();
              : 
              : 	if (!flashchips)
              : 		return NULL;
```
const struct flashchip *chip = get_flashchips()[0];
for (; chip->vendor; chip++) {
```

File libflashrom.c:

https://review.coreboot.org/c/flashrom/+/75646/comment/e7497a3f_73f35ef3 :
PS5, Line 95: unsigned int
size_t

File print.c:

https://review.coreboot.org/c/flashrom/+/75646/comment/be9da440_ff4b7a31 :
PS5, Line 56: const struct flashchip *chip;
delete

https://review.coreboot.org/c/flashrom/+/75646/comment/0bc5f4e4_9914ab1d :
PS5, Line 62: flashchips
chip

https://review.coreboot.org/c/flashrom/+/75646/comment/d6c77b67_ecd3cf69 :
PS5, Line 65: chip = flashchips
delete

File print_wiki.c:

https://review.coreboot.org/c/flashrom/+/75646/comment/86a26de7_0c05b97b :
PS5, Line 294: flashchips
get_flashchips()

https://review.coreboot.org/c/flashrom/+/75646/comment/a7599e14_85aaabe1 :
PS5, Line 310: flashchips
get_flashchips()