Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer.

View Change

11 comments:

• Patchset:

  • Patch Set #5:

    I realise this patch was a intermediate step so the comments are just how it should probably look for when the desire to merge comes about.

• File flashchips.c:

  • Patch Set #5, Line 34: internal_

    no need to rename if it becomes static, also "internal" is a overloaded term with the internal programmer.

  • Patch Set #5, Line 20844: get_flashchips(void)

    you *could* have a signature of:

    `void get_flashchip_db(struct flashchip **db, size_t *len)` ?

  • Patch Set #5, Line 20849: unsigned int

    should be `size_t` for the size of an array.

• File ichspi.c:

  • Patch Set #5, Line 1469:

    	const struct flashchip *chip;
    
    	struct flashchip *flashchips=get_flashchips();
    
    	if (!flashchips)
    		return NULL;
    

    ```
    const struct flashchip *chip = get_flashchips()[0];
    for (; chip->vendor; chip++) {
    ```

• File libflashrom.c:

  • Patch Set #5, Line 95: unsigned int

    size_t

• File print.c:

  • Patch Set #5, Line 56: const struct flashchip *chip;

    delete

  • Patch Set #5, Line 62: flashchips

    chip

  • Patch Set #5, Line 65: chip = flashchips

    delete

• File print_wiki.c:

  • Patch Set #5, Line 294: flashchips

    get_flashchips()

  • Patch Set #5, Line 310: flashchips

    get_flashchips()

To view, visit change 75646. To unsubscribe, or for help writing mail filters, visit settings.