David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38596 )
Change subject: flashcips: Add Spansion S25FL512S ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Thanks! I also happen to have one of these chips handy, and was able to get reads, erase, and writes working using native 4BA instructions (erase opcode DC).
I have a bit more testing to do and some more comments, so marking as -1 for now.
https://review.coreboot.org/c/flashrom/+/38596/3/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/38596/3/flashchips.c@15979 PS3, Line 15979: FEATURE_4BA_EAR7 I was able to get erase/writes working when using FEATURE_4BA_NATIVE