Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35830 )
Change subject: linux_spi: add missing include ......................................................................
Patch Set 3: Code-Review+2
(3 comments)
I'm ok with the change, just the reasoning seems completely wrong. It also deserves a comment above the includes that we keep the order because we expect broken header files.
https://review.coreboot.org/c/flashrom/+/35830/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/35830/3//COMMIT_MSG@7 PS3, Line 7: missing This looks more like a workaround for broken kernel header files to me.
https://review.coreboot.org/c/flashrom/+/35830/3//COMMIT_MSG@11 PS3, Line 11: from linux/spi/spidev.h Really walks like a bug, talks like a bug in `linux/spi/spidev.h`.
https://review.coreboot.org/c/flashrom/+/35830/3//COMMIT_MSG@13 PS3, Line 13: Fixes build errors with the musl C library. IIRC, Alpine Linux uses musl libc and that always built fine...