I'm ok with the change, just the reasoning seems completely
wrong. It also deserves a comment above the includes that
we keep the order because we expect broken header files.

Patch set 3:Code-Review +2

View Change

3 comments:

To view, visit change 35830. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ieab60f59bc63aca0dc4867f31699dab4167da05b
Gerrit-Change-Number: 35830
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 08 Oct 2019 10:04:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment