4 Nov
2022
4 Nov
'22
8:29 p.m.
Attention is currently required from: Felix Singer, Artur Kowalski.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68557 )
Change subject: flashchips: add support for MX77L25650F chip ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/68557/comment/b280c09d_354da788 PS1, Line 10215: // TODO: add 64K block erase
We haven't tested 64K erase so I didn't add it here.
We typically add all block erasers supported by the flash chip, from smallest block size to largest block size. flashrom currently doesn't use them unless there's an error.
--
To view, visit https://review.coreboot.org/c/flashrom/+/68557
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaea5485f8b59b8538dc47beada2c308376ea027c
Gerrit-Change-Number: 68557
Gerrit-PatchSet: 3
Gerrit-Owner: Artur Kowalski artur.kowalski@3mdeb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Artur Kowalski artur.kowalski@3mdeb.com
Gerrit-Comment-Date: Fri, 04 Nov 2022 20:29:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Artur Kowalski artur.kowalski@3mdeb.com
Gerrit-MessageType: comment