Attention is currently required from: Felix Singer, Artur Kowalski.
Patch set 3:Code-Review +1
View Change
1 comment:
File flashchips.c:
Patch Set #1, Line 10215: // TODO: add 64K block erase
We haven't tested 64K erase so I didn't add it here.
We typically add all block erasers supported by the flash chip, from smallest block size to largest block size. flashrom currently doesn't use them unless there's an error.
To view, visit change 68557. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaea5485f8b59b8538dc47beada2c308376ea027c
Gerrit-Change-Number: 68557
Gerrit-PatchSet: 3
Gerrit-Owner: Artur Kowalski <artur.kowalski@3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Artur Kowalski <artur.kowalski@3mdeb.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 20:29:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Artur Kowalski <artur.kowalski@3mdeb.com>
Gerrit-MessageType: comment