Attention is currently required from: Richard Hughes, Angel Pons, Patrick Rudolph. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 )
Change subject: libflashrom: Return progress state to the library user ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49643/comment/19007be0_a919d018 PS4, Line 9: Include test for the dummy spi25 device. If you could elaborate more on what this commit is doing, it would be great. Maybe add a paragraph explaining the change in more details?
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/49643/comment/4b938cc4_968242e6 PS4, Line 106: void * Is there a reason why last argument doesn't have a name here? all other arguments have names.
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/6676a19e_d98d9810 PS4, Line 113: private This function doesn't look to be private, it is called outside of this file.
File tests/spi25.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/c5032b8f_f4aa73cb PS4, Line 54: size_t current, Thank you for the test! Is there any way to assert what current value is? it should change (unlike total) right?