Attention is currently required from: Richard Hughes, Angel Pons, Patrick Rudolph.

View Change

4 comments:

• Commit Message:

  • Patch Set #4, Line 9: Include test for the dummy spi25 device.

    If you could elaborate more on what this commit is doing, it would be great. Maybe add a paragraph explaining the change in more details?

• File libflashrom.h:

  • Patch Set #4, Line 106: void *

    Is there a reason why last argument doesn't have a name here? all other arguments have names.

• File libflashrom.c:

  • Patch Set #4, Line 113: private

    This function doesn't look to be private, it is called outside of this file.

• File tests/spi25.c:

  • Patch Set #4, Line 54: size_t current,

    Thank you for the test! Is there any way to assert what current value is? it should change (unlike total) right?

To view, visit change 49643. To unsubscribe, or for help writing mail filters, visit settings.