[flashrom-gerrit] Change in flashrom[master]: layout: Introduce flashrom_layout_new()

[Peter Marheine (Code Review)]

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33543 )

Change subject: layout: Introduce flashrom_layout_new()
......................................................................


Patch Set 7:

(1 comment)

File layout.c:

https://review.coreboot.org/c/flashrom/+/33543/comment/daef5314_33e71349 
PS5, Line 397: malloc
> I am not used to such errors, so I need much more details about […]
> My main thought is that it becomes easier to debug failures because they'll crash predictably rather than possibly not crashing or behaving erratically.

Maybe Ed had something else in mind; I don't have a very strong opinion either way, considering it would be well within the realm of environment configuration to ask libc to zero or randomize allocated memory as a debugging option.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/33543
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2ae7246493ff592e631cce924777925c7825e398
Gerrit-Change-Number: 33543
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Daniel Campello <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Peter Marheine <[e-mail]>
Gerrit-Reviewer: Thomas Heijligen <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Daniel Campello <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Comment-Date: Mon, 21 Jun 2021 23:27:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <[e-mail]>
Comment-In-Reply-To: Edward O'Callaghan <[e-mail]>
Comment-In-Reply-To: Peter Marheine <[e-mail]>
Gerrit-MessageType: comment