Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Evan Benn.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79304?usp=email )
Change subject: flashrom_tester: Fix partial_lock_test on libflashrom ......................................................................
Patch Set 4:
(2 comments)
File util/flashrom_tester/Cargo.toml:
https://review.coreboot.org/c/flashrom/+/79304/comment/feca2f69_92a9220f : PS3, Line 25: libflashrom = { path = "../../bindings/rust/libflashrom" }
I am curious: why it was working before, without this line?
This is for the `use libflashrom::FlashromFlags;` in `util/flashrom_tester/src/tester.rs`, where we didn't need `libflashrom` in that file before.
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/79304/comment/ea645ee9_7ba6d13a : PS3, Line 301: // TODO
Did you mean to do something here?
The flashrom CLI sets its own default flags, and we currently have no need for custom flags, so this set_flags function is intentionally a no-op.
(Change the comments)