[flashrom-gerrit] [M] Change in flashrom[main]: libflashrom: Update the API for progress callback

[Sergii Dmytruk (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Richard Hughes.

Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )

Change subject: libflashrom: Update the API for progress callback
......................................................................

Patch Set 3:

(1 comment)

File include/libflashrom.h:

https://review.coreboot.org/c/flashrom/+/86031/comment/1ad6f14b_fa159f40?usp... :
PS2, Line 90:  * @deprecated Use flashrom_set_progress_callback_v1 instead
> Half of this was forgetting, but other half that I haven't done changes on the live API before. […]

Well, it's not backwards compatible for sure.  Applications using the library will build, but won't work and there is no guarantee that the message will be noticed.

It depends whether API is supposed to remain compatible.  If so, I think it can be done by storing 2 callbacks, but at most one of them could be active at a time.