Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Richard Hughes.

View Change

1 comment:

• File include/libflashrom.h:

  • Patch Set #2, Line 90: * @deprecated Use flashrom_set_progress_callback_v1 instead

    Half of this was forgetting, but other half that I haven't done changes on the live API before. […]

    Well, it's not backwards compatible for sure. Applications using the library will build, but won't work and there is no guarantee that the message will be noticed.

    It depends whether API is supposed to remain compatible. If so, I think it can be done by storing 2 callbacks, but at most one of them could be active at a time.

To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.