Attention is currently required from: Xiang Wang, Paul Menzel, Angel Pons. Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49637 )
Change subject: ft2232_spi.c: Generalize GPIOL pin control ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49637/comment/441f8f4b_3ffc4bac PS5, Line 7: Generalized GPIOL pin control
Please make it a statement, e.g.: […]
Done
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/49637/comment/845bfa2f_b10eaf5b PS5, Line 377: cs_bits
pinlvl ?
I think you're suggesting a change of variable name from cs_bits to pinlvl, right?
SGTM. It will touch many lines, so I'll do it in a separate change.
https://review.coreboot.org/c/flashrom/+/49637/comment/a226563a_df14d903 PS5, Line 381:
This would allow overriding the settings for some programmers
Good point.
I made a fourth value 'Z' to indicate overriding a programmer default and force a pin to be an input.
https://review.coreboot.org/c/flashrom/+/49637/comment/1cbf176c_c710c85d PS5, Line 384:
Using the default value can work, but it is recommended to add the following code to make the meanin […]
Thanks. I made this the 'Z' case, while allowing 'X' to mean 'accept the programmer default'.