Attention is currently required from: Xiang Wang, Paul Menzel, Angel Pons.

View Change

4 comments:

• Commit Message:

  • Patch Set #5, Line 7: Generalized GPIOL pin control

    Please make it a statement, e.g.: […]

    Done

• File ft2232_spi.c:

  • Patch Set #5, Line 377: cs_bits

    pinlvl ?

    I think you're suggesting a change of variable name from cs_bits to pinlvl, right?

    SGTM. It will touch many lines, so I'll do it in a separate change.

  • Patch Set #5, Line 381:

    This would allow overriding the settings for some programmers

    Good point.

    I made a fourth value 'Z' to indicate overriding a programmer default and force a pin to be an input.

  • Patch Set #5, Line 384:

    Using the default value can work, but it is recommended to add the following code to make the meanin […]

    Thanks. I made this the 'Z' case, while allowing 'X' to mean 'accept the programmer default'.

To view, visit change 49637. To unsubscribe, or for help writing mail filters, visit settings.