Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Richard Hughes.
Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )
Change subject: libflashrom: Update the API for progress callback ......................................................................
Patch Set 5:
(1 comment)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/86031/comment/ec2c2ef3_24e76356?usp... : PS2, Line 90: * @deprecated Use flashrom_set_progress_callback_v1 instead
I wrote all the code to handle two callbacks, with v2 callback having priority (still have the code […]
That doesn't strike me as a problem. There could still be a pointer to a client-managed progress state along with the internal state, just need to copy data into the former before invoking v1 callback.
Overall, a more convenient callback just doesn't seem to me like a good enough reason for breaking any compatibility. On the other hand, repology.org shows only a single `libflashrom` package.