Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Richard Hughes.

View Change

1 comment:

• File include/libflashrom.h:

  • Patch Set #2, Line 90: * @deprecated Use flashrom_set_progress_callback_v1 instead

    I wrote all the code to handle two callbacks, with v2 callback having priority (still have the code […]

    That doesn't strike me as a problem. There could still be a pointer to a client-managed progress state along with the internal state, just need to copy data into the former before invoking v1 callback.

    Overall, a more convenient callback just doesn't seem to me like a good enough reason for breaking any compatibility. On the other hand, repology.org shows only a single `libflashrom` package.

To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.