Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Anastasia Klimchuk.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c:Add helper functions needed for new erase selction algorithm ......................................................................
Patch Set 80:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/65844/comment/8ca640a7_2d315840 PS80, Line 7: flashrom.c:Add helper functions needed for new erase selction algorithm
There are few small things (missing space and one typo), having in mind 72 char limit I suggest to r […]
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/882837f7_0c8096b8 PS80, Line 9: 1)Add a function
Add space between number and text (and same for below).
Done
Patchset:
PS78:
Looks like this comment resolved? Edward what do you think? I see this patch is end result of squash […]
Done
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/9f0cc4f8_52340ece PS80, Line 115:
Remove one empty line (there are two empty lines in a row)
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/e5c3a12e_71518dec PS80, Line 173: !!
I think one exclamation mark is enough :) […]
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/c2eac7dd_7311b679 PS80, Line 198: if (ll->start_addr >= rstart && : ll->end_addr <= rend) {
This can be one line (will be more readable)
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/3bb723ec_1c2fbffd PS80, Line 219: if (ll->start_addr >= rstart && : ll->end_addr <= rend) {
Here too: make this one line, for better readability
Done