Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Anastasia Klimchuk.
7 comments:
Commit Message:
Patch Set #80, Line 7: flashrom.c:Add helper functions needed for new erase selction algorithm
There are few small things (missing space and one typo), having in mind 72 char limit I suggest to r […]
Done
Patch Set #80, Line 9: 1)Add a function
Add space between number and text (and same for below).
Done
Patchset:
Looks like this comment resolved? Edward what do you think? I see this patch is end result of squash […]
Done
File erasure_layout.c:
Remove one empty line (there are two empty lines in a row)
Done
I think one exclamation mark is enough :) […]
Done
if (ll->start_addr >= rstart &&
ll->end_addr <= rend) {
This can be one line (will be more readable)
Done
if (ll->start_addr >= rstart &&
ll->end_addr <= rend) {
Here too: make this one line, for better readability
Done
To view, visit change 65844. To unsubscribe, or for help writing mail filters, visit settings.