Attention is currently required from: Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54712 )
Change subject: sb600spi.c: Move sb600_spibar into spi data instead of being global ......................................................................
Patch Set 1:
(1 comment)
File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/54712/comment/92a98b88_e8a9802d PS1, Line 610: free(data);
`sb600_spibar` is not a pointer to dynamically-allocated memory, so it must not be free()'d. […]
rphysmap() is rather special. Actually many functions with an `r` prefix in flashrom. AIUI, the `r` means that the effects of a successful call shall be reversed once flashrom exits. There's some automatism that registers shutdown functions for this.
In the long run, we should move the global state of shutdown registrations into some kind of library context. We could also move more things into the programmer-local shutdown functions, but that's independent. For now, there is nothing that needs to be done for `r` function calls.