Attention is currently required from: Anastasia Klimchuk.

View Change

1 comment:

• File sb600spi.c:

  • Patch Set #1, Line 610: free(data);

    `sb600_spibar` is not a pointer to dynamically-allocated memory, so it must not be free()'d. […]

    rphysmap() is rather special. Actually many functions with an `r` prefix
    in flashrom. AIUI, the `r` means that the effects of a successful call
    shall be reversed once flashrom exits. There's some automatism that
    registers shutdown functions for this.

    In the long run, we should move the global state of shutdown registrations
    into some kind of library context. We could also move more things into the
    programmer-local shutdown functions, but that's independent. For now, there
    is nothing that needs to be done for `r` function calls.

To view, visit change 54712. To unsubscribe, or for help writing mail filters, visit settings.