David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31248 )
Change subject: Add support for the meson build system
......................................................................
Patch Set 2: Code-Review+2
Seems fine IMO, but we should check with Nico since he's currently the most active maintainer. There's some extra maintenance burden, but it seems like a worthy trade-off for the extra testing and CI we get in return.
Maybe we can come up with some clever ways to reduce duplicated logic, like generating some of the repetitive if-statements. Make can include other Makefiles, and there is a PR for Meson to be able to include() other .build files (https://github.com/mesonbuild/meson/pull/3557).
But that shouldn't be a gating factor for now.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/31248
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d950ece2a0568c09985eab47ddab9df1d0c43a2
Gerrit-Change-Number: 31248
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 03 Mar 2019 00:32:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
