Seems fine IMO, but we should check with Nico since he's currently the most active maintainer. There's some extra maintenance burden, but it seems like a worthy trade-off for the extra testing and CI we get in return.

Maybe we can come up with some clever ways to reduce duplicated logic, like generating some of the repetitive if-statements. Make can include other Makefiles, and there is a PR for Meson to be able to include() other .build files (https://github.com/mesonbuild/meson/pull/3557).

But that shouldn't be a gating factor for now.

Patch set 2:Code-Review +2

View Change

To view, visit change 31248. To unsubscribe, or for help writing mail filters, visit settings.