David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31018 )
Change subject: Implement IFWI layout reading ......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Mostly looks good, just a couple potential issues.
https://review.coreboot.org/c/flashrom/+/31018/3/ifwi.c File ifwi.c:
https://review.coreboot.org/c/flashrom/+/31018/3/ifwi.c@242 PS3, Line 242: char _name[sizeof((*layout)->entries[0].name)]; Don't you need to allocate memory and set (*layout)->entries[0].name? I see that new_layout() is called, but that only allocates size for the structs themselves, right?
https://review.coreboot.org/c/flashrom/+/31018/3/ifwi.c@368 PS3, Line 368: free(*layout); flashrom_layout_release(*layout)?