Mostly looks good, just a couple potential issues.

Patch set 3:Code-Review -1

View Change

2 comments:

• File ifwi.c:

  • Patch Set #3, Line 242: char _name[sizeof((*layout)->entries[0].name)];

    Don't you need to allocate memory and set (*layout)->entries[0].name? I see that new_layout() is called, but that only allocates size for the structs themselves, right?

  • Patch Set #3, Line 368: free(*layout);

    flashrom_layout_release(*layout)?

To view, visit change 31018. To unsubscribe, or for help writing mail filters, visit settings.