HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34405 )
Change subject: cli_classic: Fix Memory leak ......................................................................
Patch Set 2:
(2 comments)
Thank you
https://review.coreboot.org/c/flashrom/+/34405/1/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/34405/1/cli_classic.c@386 PS1, Line 386: logfile[0] != '\0'
nit, just `if (logfile)` would be enough. It was initialized to `NULL` above, […]
Done. Thank you.
https://review.coreboot.org/c/flashrom/+/34405/1/cli_classic.c@387 PS1, Line 387: Warning: log file not free of older string. Running free() rightnow.\n
Well, if we follow the code flow, it's clear that this happens (only) when […]
Done, Thx