Thank you
View Change
2 comments:
File cli_classic.c:
Patch Set #1, Line 386: logfile[0] != '\0'
nit, just `if (logfile)` would be enough. It was initialized to `NULL` above, […]
Done.
Thank you.
Patch Set #1, Line 387: Warning: log file not free of older string. Running free() rightnow.\n
Well, if we follow the code flow, it's clear that this happens (only) when […]
Done,
Thx
To view, visit change 34405. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I84e642b57b95953f376569e443ef8d8eda7bf98f
Gerrit-Change-Number: 34405
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Thu, 18 Jul 2019 15:34:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment