David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42556 )
Change subject: [RFC] Add uncrustify config ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://review.coreboot.org/c/flashrom/+/42556/3/bitbang_spi.c File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/42556/3/bitbang_spi.c@19 PS3, Line 19: #include <ctype.h>
Uh, do we want global headers above local headers?
No, but I think this can be fixed by separating the global headers and local headers with a newline. Here is the documentation for the #include sorting option:
# Whether to sort consecutive single-line '#include' statements (C/C++) and # '#import' statements (Objective-C). Be aware that this has the potential to # break your code if your includes/imports have ordering dependencies. mod_sort_include = false # true/false