Patch set 3:Code-Review -1

View Change

1 comment:

• File bitbang_spi.c:

  • Patch Set #3, Line 19: #include <ctype.h>

    Uh, do we want global headers above local headers?

    No, but I think this can be fixed by separating the global headers and local headers with a newline. Here is the documentation for the #include sorting option:

    # Whether to sort consecutive single-line '#include' statements (C/C++) and
    # '#import' statements (Objective-C). Be aware that this has the potential to
    # break your code if your includes/imports have ordering dependencies.
    mod_sort_include = false # true/false

To view, visit change 42556. To unsubscribe, or for help writing mail filters, visit settings.