Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37987 )
Change subject: chipset_enable.c: Add Ice Lake U to known systems ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG@7 PS3, Line 7: known systems That's not entirely true: It is adding ICL-U as known *and* tested. Has it been tested (read/write/erase)?
https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG@9 PS3, Line 9: underdescribed `undocumented` sounds better
https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG@9 PS3, Line 9: Systems `systems` in lowercase
https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG@9 PS3, Line 9: an (so far) this looks rather weird. Maybe use 'a currently' instead?
https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG@10 PS3, Line 10: compaitble Not fixed?