Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37987 ) Change subject: chipset_enable.c: Add Ice Lake U to known systems ...................................................................... Patch Set 3: (5 comments) https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG@7 PS3, Line 7: known systems That's not entirely true: It is adding ICL-U as known *and* tested. Has it been tested (read/write/erase)? https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG@9 PS3, Line 9: underdescribed `undocumented` sounds better https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG@9 PS3, Line 9: Systems `systems` in lowercase https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG@9 PS3, Line 9: an (so far) this looks rather weird. Maybe use 'a currently' instead? https://review.coreboot.org/c/flashrom/+/37987/3//COMMIT_MSG@10 PS3, Line 10: compaitble Not fixed? -- To view, visit https://review.coreboot.org/c/flashrom/+/37987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6227d32f4476420cf1aeec37ebd4b7648e0b3d15 Gerrit-Change-Number: 37987 Gerrit-PatchSet: 3 Gerrit-Owner: Mimoja <coreboot@mimoja.de> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Mimoja <coreboot@mimoja.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-Comment-Date: Thu, 09 Jan 2020 21:22:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment