Attention is currently required from: Felix Singer, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62196 )
Change subject: Makefile: use HAS_ USE_ pattern for serial support ......................................................................
Patch Set 2:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/62196/comment/e5c800c6_82f3ad6e PS2, Line 807: ifneq ($(NEED_POSIX_SOCKETS), ) Not sure about this. It seems special to serprog. It looks like currently the set of OSes that don't support it matches the set with serial support. But that's coincidence, I guess.
It definitely looks odd to place the LDFLAGS under USE_SERIAL. Maybe move it to the SERPROG check. Or even add a DEPENDS_ON_SOCKETS group?