Attention is currently required from: Felix Singer, Thomas Heijligen.
View Change
1 comment:
File Makefile:
Patch Set #2, Line 807: ifneq ($(NEED_POSIX_SOCKETS), )
Not sure about this. It seems special to serprog. It looks like currently
the set of OSes that don't support it matches the set with serial support.
But that's coincidence, I guess.
It definitely looks odd to place the LDFLAGS under USE_SERIAL. Maybe move
it to the SERPROG check. Or even add a DEPENDS_ON_SOCKETS group?
To view, visit change 62196. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66
Gerrit-Change-Number: 62196
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 14:28:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment