Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69268 )
Change subject: tests: Add llvm-cov option and run target for code coverage ......................................................................
Patch Set 12:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69268/comment/a533f182_43fd0e6b PS11, Line 14: TEST=meson test; ninja llvm-cov-tests
Can you test scenario when feature disables? when tests disabled? […]
I ran it for all the test_build configs with coverage enabled, anad with and without tests.
Patchset:
PS11:
I dont mind doing that, but is it necessary? The script is in the repo. […]
Done
File meson.build:
https://review.coreboot.org/c/flashrom/+/69268/comment/2e20ae40_5b7222ce PS5, Line 534: if get_option('llvm_cov')
I am confused, but what does it mean, coverage without running tests?
code coverage is an independent concept from unit tests. you can collect code coverage on a run of the CLI. This would be useful for integration tests, or for debugging in general.
File meson.build:
https://review.coreboot.org/c/flashrom/+/69268/comment/5eee5dd1_8810e07e PS11, Line 614: run_target('llvm-cov-cli', command : ['scripts/llvm-cov', classic_cli])
This should also be guarded
Done