Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
4 comments:
Commit Message:
Patch Set #11, Line 14: TEST=meson test; ninja llvm-cov-tests
Can you test scenario when feature disables? when tests disabled? […]
I ran it for all the test_build configs with coverage enabled, anad with and without tests.
Patchset:
I dont mind doing that, but is it necessary? The script is in the repo. […]
Done
File meson.build:
Patch Set #5, Line 534: if get_option('llvm_cov')
I am confused, but what does it mean, coverage without running tests?
code coverage is an independent concept from unit tests. you can collect code coverage on a run of the CLI. This would be useful for integration tests, or for debugging in general.
File meson.build:
Patch Set #11, Line 614: run_target('llvm-cov-cli', command : ['scripts/llvm-cov', classic_cli])
This should also be guarded
Done
To view, visit change 69268. To unsubscribe, or for help writing mail filters, visit settings.