Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Adds support for USB SPI protocol V2 ......................................................................
Patch Set 5: Code-Review+1
(5 comments)
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c@1024 PS5, Line 1024: transmit no need for the status intermediate, just return transmit_packet() directly.
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c@1139 PS5, Line 1139: ; \n
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c@1221 PS5, Line 1221: } \n
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c@1227 PS5, Line 1227: if (!status) { : if (read_ctx.receive_size == read_ctx.receive_index) { : /* Successful transfer. */ : return status; : } else { : /* Report the error from the failed read. */ : status = USB_SPI_HOST_RX_READ_FAILURE; : } : } : : if (status) { Is this just equivalent to:
``` if (!status && (read_ctx.receive_size == read_ctx.receive_index)) return 0; /* Successful transfer. */
/* Report the error from the failed read. */ status = USB_SPI_HOST_RX_READ_FAILURE;
/* Read operation failed. */ msg_perr("Raiden: Read response failed\n" ... ```
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c@1257 PS5, Line 1257: } \n