Patch set 5:Code-Review +1

View Change

5 comments:

• File raiden_debug_spi.c:

  • Patch Set #5, Line 1024: transmit

    no need for the status intermediate, just return transmit_packet() directly.

  • Patch Set #5, Line 1139: ;

    \n

  • Patch Set #5, Line 1221: }

    \n

  • Patch Set #5, Line 1227:

    if (!status) {
    				if (read_ctx.receive_size == read_ctx.receive_index) {
    					/* Successful transfer. */
    					return status;
    				} else {
    					/* Report the error from the failed read. */
    					status = USB_SPI_HOST_RX_READ_FAILURE;
    				}
    			}
    
    			if (status) {
    

    Is this just equivalent to:

    ```
    if (!status && (read_ctx.receive_size == read_ctx.receive_index))
        return 0; /* Successful transfer. */

    /* Report the error from the failed read. */
    status = USB_SPI_HOST_RX_READ_FAILURE;

    /* Read operation failed. */
    msg_perr("Raiden: Read response failed\n"
       ...
    ```

  • Patch Set #5, Line 1257: }

    \n

To view, visit change 41533. To unsubscribe, or for help writing mail filters, visit settings.