Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c ......................................................................
Patch Set 16: Code-Review+1
(3 comments)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/2c39715e_d1b01bd4 PS16, Line 111: return 0x00; /* ENE_KB932.ec_is_running mask */ This else path should have braces, too. The rule is to have them on all branches of an `if`/`else if`/`else` if any of them needs braces.
File tests/io_mock.h:
https://review.coreboot.org/c/flashrom/+/51487/comment/f2d45ee2_6ec1bcfb PS13, Line 37: unsigned char
I put your types back: I see you did way more thinking about this. […]
I don't mind. `state` works too 😊
I've noticed now that the wrapper functions use the stdint types. I don't care much, but that's something we could unify.
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/fb048139_2a920abf PS16, Line 95: */ I'm not a fan of such comments. It's too obvious and such boilerplate distracts from the code.