Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

Patch set 16:Code-Review +1

View Change

3 comments:

• File tests/init_shutdown.c:

  • Patch Set #16, Line 111: return 0x00; /* ENE_KB932.ec_is_running mask */

    This else path should have braces, too. The rule is to have them on
    all branches of an `if`/`else if`/`else` if any of them needs braces.

• File tests/io_mock.h:

  • Patch Set #13, Line 37: unsigned char

    I put your types back: I see you did way more thinking about this. […]

    I don't mind. `state` works too 😊

    I've noticed now that the wrapper functions use the stdint types. I don't
    care much, but that's something we could unify.

• File tests/tests.c:

  • Patch Set #16, Line 95: */

    I'm not a fan of such comments. It's too obvious and such boilerplate
    distracts from the code.

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.