[flashrom-gerrit] Change in flashrom[master]: spi25: Add 'spi_read_status_register_2()' helper

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45748 )

Change subject: spi25: Add 'spi_read_status_register_2()' helper
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/flashrom/+/45748/3/spi25_statusreg.c 
File spi25_statusreg.c:

https://review.coreboot.org/c/flashrom/+/45748/3/spi25_statusreg.c@118 
PS3, Line 118: 	return spi_read_status_register_generic(flash, 0x35); /* Unclear if this is a std JEDEC opcode. */
> That is some decent research thanks! Tricky ok.. […]

I'd prefer if there was an abstraction somewhere to cleanly map high-level operations (e.g. handle write protect stuff) to lower-level stuff (SPI commands). There's some sort of layering in flashrom, but it seems to have degraded over time.