View Change
1 comment:
File spi25_statusreg.c:
Patch Set #3, Line 118: return spi_read_status_register_generic(flash, 0x35); /* Unclear if this is a std JEDEC opcode. */
That is some decent research thanks! Tricky ok.. […]
I'd prefer if there was an abstraction somewhere to cleanly map high-level operations (e.g. handle write protect stuff) to lower-level stuff (SPI commands). There's some sort of layering in flashrom, but it seems to have degraded over time.
To view, visit change 45748. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d25f22ced17ab94d122e86b270357723b45458e
Gerrit-Change-Number: 45748
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 28 Sep 2020 18:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment