Attention is currently required from: Wonkyu Kim, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62783 )
Change subject: ichspi: Add support for Meteor Lake ......................................................................
Patch Set 6:
(3 comments)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/7da34ab6_5c0100c4 PS5, Line 310: case CHIPSET_METEOR_LAKE:
Is this correct?
Yes, I have verified with MTL SPI programming guide.
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/628caea6_a0881d21 PS5, Line 2062: ich_gen == CHIPSET_METEOR_LAKE)) {
Please keep this aligned with the previous conditions. […]
Ack
File programmer.h:
https://review.coreboot.org/c/flashrom/+/62783/comment/e8e0611a_ef464ce8 PS5, Line 357: CHIPSET_METEOR_LAKE,
Any particular reason to put this here? I'd expect this to come after `CHIPSET_ELKHART_LAKE` to preserve chronological ordering and PCH/non-PCH grouping.
Or is this placed after `CHIPSET_600_SERIES_ALDER_POINT`?
You got it right, it's the successor of ADL hence, put as per the order.