Attention is currently required from: Wonkyu Kim, Angel Pons, Anastasia Klimchuk.

View Change

3 comments:

• File ich_descriptors.c:

  • Patch Set #5, Line 310: case CHIPSET_METEOR_LAKE:

    Is this correct?

    Yes, I have verified with MTL SPI programming guide.

• File ichspi.c:

  • Patch Set #5, Line 2062: ich_gen == CHIPSET_METEOR_LAKE)) {

    Please keep this aligned with the previous conditions. […]

    Ack

• File programmer.h:

  • Patch Set #5, Line 357: CHIPSET_METEOR_LAKE,

    Any particular reason to put this here? I'd expect this to come after `CHIPSET_ELKHART_LAKE` to preserve chronological ordering and PCH/non-PCH grouping.

    Or is this placed after `CHIPSET_600_SERIES_ALDER_POINT`?

    You got it right, it's the successor of ADL hence, put as per the order.

To view, visit change 62783. To unsubscribe, or for help writing mail filters, visit settings.