Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call ......................................................................
Patch Set 11:
(5 comments)
Patch Set 11:
Anyone having time to give some feedback?
Well, I see three different changes on this commit, and would prefer to split them up.
https://review.coreboot.org/c/flashrom/+/40477/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/40477/8//COMMIT_MSG@17 PS8, Line 17: https://ibb.co/0c1J25d
How do I better? Is there a better way to provide images? Just let me know.
I wouldn't provide them in a commit message
https://review.coreboot.org/c/flashrom/+/40477/11/ft2232_spi.c File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/11/ft2232_spi.c@403 PS11, Line 403: if (ftdi_write_data_set_chunksize(ftdic, 280)) { : /* : * 280 bytes = : * + 9 B (CMD) : * + 1 B (WREN) : * + 9 B (CMD) : * + 1 B (op) : * + 4 B (addr) : * + 256 B (page data) : * : * With op: PageProgram or Erase; CMD: FTDI-Chip commands : */ Increasing the chunksize can be the 1st commit
https://review.coreboot.org/c/flashrom/+/40477/11/ft2232_spi.c@481 PS11, Line 481: static unsigned char buf[FTDI_HW_BUFFER_SIZE]; Using a fixed-size buffer can be the 2nd commit
https://review.coreboot.org/c/flashrom/+/40477/11/ft2232_spi.c@483 PS11, Line 483: static int i = 0; This line is part of the 3rd commit
https://review.coreboot.org/c/flashrom/+/40477/11/ft2232_spi.c@541 PS11, Line 541: if (writearr[0] == JEDEC_WREN) { : /* Return to get second op (Program or Erase) without resetting buf nor i*/ : return 0; : } else { : ret = send_buf(ftdic, buf, i); : i = 0; : } This is the rest of the 3rd commit