Patch Set 11:

Anyone having time to give some feedback?

Well, I see three different changes on this commit, and would prefer to split them up.

View Change

5 comments:

• Commit Message:

  • Patch Set #8, Line 17: https://ibb.co/0c1J25d

    How do I better? Is there a better way to provide images? Just let me know.

    I wouldn't provide them in a commit message

• File ft2232_spi.c:

  • Patch Set #11, Line 403:

    if (ftdi_write_data_set_chunksize(ftdic, 280)) {
    		/*
    		* 280 bytes =
    		*   + 9 B (CMD)
    		*   + 1 B (WREN)
    		*   + 9 B (CMD)
    		*   + 1 B (op)
    		*   + 4 B (addr)
    		*   + 256 B (page data)
    		*
    		* With op: PageProgram or Erase; CMD: FTDI-Chip commands
    		*/
    

    Increasing the chunksize can be the 1st commit

  • Patch Set #11, Line 481: static unsigned char buf[FTDI_HW_BUFFER_SIZE];

    Using a fixed-size buffer can be the 2nd commit

  • Patch Set #11, Line 483: static int i = 0;

    This line is part of the 3rd commit

  • Patch Set #11, Line 541:

    if (writearr[0] == JEDEC_WREN) {
    		/* Return to get second op (Program or Erase) without resetting buf nor i*/
    		return 0;
    	} else {
    		ret = send_buf(ftdic, buf, i);
    		i = 0;
    	}
    

    This is the rest of the 3rd commit

To view, visit change 40477. To unsubscribe, or for help writing mail filters, visit settings.