[flashrom-gerrit] [XS] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G

[Name of user not set (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.

Name of user not set #1005084 has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76853?usp=email )

Change subject: flashchips: Add support for MXIC MX25U25643G
......................................................................

Patch Set 3:

(9 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/76853/comment/ae7c9169_e524153f :
PS1, Line 7: MX2525643G
> Let's use exact name MX25U25643G , can you please update?

Done

https://review.coreboot.org/c/flashrom/+/76853/comment/6624e780_336469ef :
PS1, Line 8: MX2525635F
> Same here, probably MX25U25635F

Done

https://review.coreboot.org/c/flashrom/+/76853/comment/2155a610_1b44321a :
PS1, Line 10: Tested: read, write and erase.
> Could you please add info which programmer you ran?

Done

https://review.coreboot.org/c/flashrom/+/76853/comment/3a10c1c4_e7ffdd15 :
PS1, Line 12: Datasheet is available at the following URL:
            : https://www.mxic.com.tw/Lists/Datasheet/Attachments/8766/MX2525643G,%201.8V....
> You need to update the link (the new one you gave me in the comment works)

Done

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/76853/comment/4938e3cb_adb2727c :
PS1, Line 10094: MACRONIX_MX25U25643G
> After you fix my other comment about id, you will change this to MACRONIX_MX25U25635F

Done

https://review.coreboot.org/c/flashrom/+/76853/comment/1891de3a_eef097c3 :
PS1, Line 10104: {
               : 				.eraseblocks = { {4 * 1024, 8192} },
               : 				.block_erase = SPI_BLOCK_ERASE_21,
               : 			},
> Maybe I am missing something, I don't see this in the datasheet. […]

I compared the two chips MX25U25635F and MX25U25635F, and the two chips used almost the same command set. In 4 Byte Address Command Set, 21h for sector erase.

https://review.coreboot.org/c/flashrom/+/76853/comment/9f5854f4_47ae2140 :
PS1, Line 10113: {
               : 				.eraseblocks = { {32 * 1024, 1024} },
               : 				.block_erase = SPI_BLOCK_ERASE_52,
               : 			},
> same

Done

https://review.coreboot.org/c/flashrom/+/76853/comment/60472063_6504f289 :
PS1, Line 10117: 	.eraseblocks = { {64 * 1024, 512} },
               : 				.block_erase = SPI_BLOCK_ERASE_DC,
               : 			}, {
> same

Done

File include/flashchips.h:

https://review.coreboot.org/c/flashrom/+/76853/comment/bb450622_58b47add :
PS1, Line 530: #define MACRONIX_MX25U25643G	0x2539
> Don't add the same id, add a comment on existing id (MACRONIX_MX25U25635F), like that: […]

Done