Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58479 )
Change subject: libflashrom,writeprotect: add functions for reading/writing WP settings
......................................................................
Patch Set 25:
(4 comments)
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58479/comment/d472e6ce_9db44993
PS22, Line 129: };
Please move to the commit that makes use of it.
Done
https://review.coreboot.org/c/flashrom/+/58479/comment/8c828b1e_eea17327
PS22, Line 131: const struct flashrom_flashctx *, struct flashrom_wp_chip_config *
Something about APIs in general. We are used to have the destination […]
Done - here and in other files/commits. I think I got all occurrences, let me know if I missed something :)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/fa897570_4f3894a9
PS22, Line 48: **
Library functions should be in a respective documentation group, e.g. @defgroup or @addtogroup.
Done
https://review.coreboot.org/c/flashrom/+/58479/comment/abdb9bf5_109adc23
PS22, Line 122: INVALID_REG
IMO it is a bit confusing when loop starts with "invalid" value. […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3ad25708c3321b8fb0216c3eaf6ffc07616537ad
Gerrit-Change-Number: 58479
Gerrit-PatchSet: 25
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Tue, 11 Jan 2022 06:26:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment